1. 10 Nov, 2015 3 commits
    • Craig Watson's avatar
      Removed UBGraphicsPolygonItem::shape() · 7a4e9d2e
      Craig Watson authored
      Long version:
      
      UBGraphicsPolygonItem::shape() sometimes caused OpenBoard to crash due to
      inifinite recursion. This is easily replicated by trying to use the
      highlighting tool.
      
      The reason is: shape() calls boundingRect(); this function's definition is:
      
           QRectF QGraphicsPolygonItem::boundingRect() const
           {
                Q_D(const QGraphicsPolygonItem);
                if (d->boundingRect.isNull()) {
                    qreal pw = pen().style() == Qt::NoPen ? qreal(0) : pen().widthF();
                    if (pw == 0.0)
                        d->boundingRect = d->polygon.boundingRect();
                    else
                        d->boundingRect = shape().controlPointRect();
                }
                return d->boundingRect;
            }
      
      In the case where pw != 0, the shape() function is called. However, it
      is shape() from the derived class, not the base class, which is called.
      In other words, UBGraphicsPolygonItem::shape() is called rather than
      QGraphicsPolygonItem::shape().
      
      This means that boundingRect() is called again from within shape(), and
      so on, causing the program to crash.
      
      The fix was simply to remove UBGraphicsPolygonItem::shape(), as it
      appears to provide the same (or very similar) functionality to that of
      the base class's shape() function.
      
      In case this shape() function actually is needed, another workaround
      should be implemented to prevent this infinite recursion.
      7a4e9d2e
    • Craig Watson's avatar
    • agriche's avatar
      cdc0311a
  2. 09 Nov, 2015 4 commits
  3. 06 Nov, 2015 7 commits
  4. 05 Nov, 2015 11 commits
  5. 08 Jun, 2015 1 commit
  6. 28 Feb, 2015 2 commits
  7. 31 Jan, 2015 2 commits
  8. 22 Jan, 2015 2 commits
  9. 19 Oct, 2014 2 commits
  10. 16 Oct, 2014 4 commits
  11. 15 Oct, 2014 1 commit
  12. 14 Oct, 2014 1 commit