- 10 Nov, 2015 3 commits
-
-
Craig Watson authored
Long version: UBGraphicsPolygonItem::shape() sometimes caused OpenBoard to crash due to inifinite recursion. This is easily replicated by trying to use the highlighting tool. The reason is: shape() calls boundingRect(); this function's definition is: QRectF QGraphicsPolygonItem::boundingRect() const { Q_D(const QGraphicsPolygonItem); if (d->boundingRect.isNull()) { qreal pw = pen().style() == Qt::NoPen ? qreal(0) : pen().widthF(); if (pw == 0.0) d->boundingRect = d->polygon.boundingRect(); else d->boundingRect = shape().controlPointRect(); } return d->boundingRect; } In the case where pw != 0, the shape() function is called. However, it is shape() from the derived class, not the base class, which is called. In other words, UBGraphicsPolygonItem::shape() is called rather than QGraphicsPolygonItem::shape(). This means that boundingRect() is called again from within shape(), and so on, causing the program to crash. The fix was simply to remove UBGraphicsPolygonItem::shape(), as it appears to provide the same (or very similar) functionality to that of the base class's shape() function. In case this shape() function actually is needed, another workaround should be implemented to prevent this infinite recursion.
-
Craig Watson authored
-
agriche authored
-
- 09 Nov, 2015 4 commits
-
-
Craig Watson authored
Removed Linux-specific define (didn't work; the function wasn't defined when compiling on Linux, for some reason)
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
-
- 06 Nov, 2015 7 commits
-
-
Craig Watson authored
Q_WS_MACX -> Q_OS_OSX Q_WS_MAC -> Q_OS_OSX Q_WS_WIN -> Q_OS_WIN Q_WS_X11 -> Q_OS_LINUX
-
Craig Watson authored
-
Craig Watson authored
Added loadAcquire() to get int value of QAtomicInt variables. (Was previously done automatically with the operatorint() of QAtomicInt)
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
-
- 05 Nov, 2015 11 commits
-
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
added 'supportedDragActions' function to replace functionality provided by 'setSupportedDragActions' function (obsolete)
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
-
Craig Watson authored
Removed deprecated QPlastiqueStyle. Replaced by stock Fusion style (new in Qt5). Change this to keep the custom look defined in UBStyle?
-
Craig Watson authored
-
Craig Watson authored
-
- 08 Jun, 2015 1 commit
-
-
Claudio Valerio authored
-
- 28 Feb, 2015 2 commits
-
-
Claudio Valerio authored
Merge branch 'SEM-WithoutDocumentMode' of 62.2.114.190:/home/git/git/OpenBoardPrivate into SEM-WithoutDocumentMode
-
Claudio Valerio authored
-
- 31 Jan, 2015 2 commits
-
-
Claudio Valerio authored
-
Claudio Valerio authored
-
- 22 Jan, 2015 2 commits
-
-
Claudio Valerio authored
-
Claudio Valerio authored
-
- 19 Oct, 2014 2 commits
-
-
Claudio Valerio authored
-
Claudio Valerio authored
-
- 16 Oct, 2014 4 commits
-
-
Claudio Valerio authored
Merge branch 'SEM-WithoutDocumentMode' of 62.2.114.190:/home/git/git/OpenBoardPrivate into SEM-WithoutDocumentMode
-
Claudio Valerio authored
-
Claudio Valerio authored
-
Claudio Valerio authored
-
- 15 Oct, 2014 1 commit
-
-
Claudio Valerio authored
-
- 14 Oct, 2014 1 commit
-
-
Claudio Valerio authored
-